Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:menu): type of MenuItem is optional #712

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Jan 10, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #712 (05ec0ea) into main (71185fc) will increase coverage by 0.00%.
The diff coverage is 92.85%.

❗ Current head 05ec0ea differs from pull request most recent head f017559. Consider uploading reports for the commit f017559 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #712   +/-   ##
=======================================
  Coverage   85.34%   85.35%           
=======================================
  Files         396      396           
  Lines        9945     9947    +2     
  Branches     2298     2304    +6     
=======================================
+ Hits         8488     8490    +2     
  Misses       1457     1457           
Impacted Files Coverage Δ
packages/components/menu/src/Menu.tsx 100.00% <ø> (ø)
...kages/components/menu/src/contents/MenuDivider.tsx 100.00% <ø> (ø)
...ges/components/menu/src/contents/MenuItemGroup.tsx 91.66% <ø> (ø)
...nents/menu/src/contents/menu-sub/InlineContent.tsx 100.00% <ø> (ø)
.../components/menu/src/contents/menu-sub/MenuSub.tsx 96.96% <ø> (ø)
...ents/menu/src/contents/menu-sub/OverlayContent.tsx 6.66% <ø> (ø)
packages/components/menu/src/token.ts 100.00% <ø> (ø)
packages/components/menu/src/types.ts 100.00% <ø> (ø)
...es/components/menu/src/contents/menu-sub/Title.tsx 91.66% <85.71%> (ø)
packages/components/menu/src/contents/MenuItem.tsx 97.05% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71185fc...f017559. Read the comment docs.

@danranVm danranVm merged commit 5d1490a into IDuxFE:main Jan 10, 2022
@danranVm danranVm deleted the feat-menu branch January 10, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant