Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:slider): unify trigger conditions for change events #721

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

imguolao
Copy link
Contributor

fix #696

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Jan 13, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #721 (0a7633c) into main (5d1490a) will decrease coverage by 0.03%.
The diff coverage is 82.00%.

❗ Current head 0a7633c differs from pull request most recent head 581a1de. Consider uploading reports for the commit 581a1de to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #721      +/-   ##
==========================================
- Coverage   85.35%   85.31%   -0.04%     
==========================================
  Files         396      396              
  Lines        9947     9943       -4     
  Branches     2304     2301       -3     
==========================================
- Hits         8490     8483       -7     
- Misses       1457     1460       +3     
Impacted Files Coverage Δ
packages/components/config/src/defaultConfig.ts 100.00% <ø> (ø)
packages/components/dropdown/src/Dropdown.tsx 9.09% <0.00%> (ø)
packages/components/dropdown/src/token.ts 100.00% <ø> (ø)
packages/components/dropdown/src/types.ts 100.00% <ø> (ø)
packages/components/i18n/src/locales/zh-CN.ts 100.00% <ø> (ø)
packages/components/menu/index.ts 100.00% <ø> (ø)
packages/components/menu/src/Menu.tsx 100.00% <ø> (ø)
...kages/components/menu/src/children/MenuDivider.tsx 100.00% <ø> (ø)
...nents/menu/src/children/menu-sub/InlineContent.tsx 100.00% <ø> (ø)
...ges/components/menu/src/composables/useExpanded.ts 70.58% <ø> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d1490a...581a1de. Read the comment docs.

Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danranVm danranVm merged commit a3209fa into IDuxFE:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:slider] onChange 事件的触发时机
2 participants