Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk:scroll): show scrollbar when mouseenter #722

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Jan 13, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Jan 13, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #722 (c323915) into main (8b5212b) will decrease coverage by 0.07%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   85.38%   85.30%   -0.08%     
==========================================
  Files         397      397              
  Lines       10079    10087       +8     
  Branches     2339     2343       +4     
==========================================
- Hits         8606     8605       -1     
- Misses       1473     1482       +9     
Impacted Files Coverage Δ
.../cdk/scroll/src/virtual/composables/useScrollTo.ts 86.20% <0.00%> (ø)
packages/cdk/scroll/src/virtual/VirtualScroll.tsx 88.09% <70.58%> (-11.91%) ⬇️
...scroll/src/virtual/composables/useScrollVisible.ts 100.00% <100.00%> (ø)
...ages/cdk/scroll/src/virtual/contents/ScrollBar.tsx 96.42% <100.00%> (ø)
...ponents/image/src/component/ImageViewerContent.tsx 86.20% <0.00%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5212b...c323915. Read the comment docs.

@danranVm danranVm merged commit cfa48ce into IDuxFE:main Jan 13, 2022
@danranVm danranVm deleted the feat-cdk-scroll branch January 13, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant