Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(comp:menu): use customXxx instead of slots #725

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

danranVm
Copy link
Member

BREAKING CHANGE: slots of MenuData is deprecated, please use customIcon, customLabel and
customSuffix instead

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

BREAKING CHANGE: `slots` of `MenuData` is deprecated,  please use `customIcon`, `customLabel` and
`customSuffix` instead
@idux-bot
Copy link

idux-bot bot commented Jan 14, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #725 (04228bd) into main (1592ea2) will decrease coverage by 0.04%.
The diff coverage is 74.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
- Coverage   85.36%   85.31%   -0.05%     
==========================================
  Files         397      397              
  Lines       10086    10101      +15     
  Branches     2344     2354      +10     
==========================================
+ Hits         8610     8618       +8     
- Misses       1476     1483       +7     
Impacted Files Coverage Δ
...s/components/menu/src/composables/useDataSource.ts 31.57% <0.00%> (-9.60%) ⬇️
packages/components/menu/src/types.ts 100.00% <ø> (ø)
...ges/components/menu/src/children/MenuItemGroup.tsx 88.88% <85.71%> (-2.42%) ⬇️
...es/components/menu/src/children/menu-sub/Title.tsx 90.00% <88.88%> (-1.43%) ⬇️
packages/components/menu/src/children/MenuItem.tsx 100.00% <100.00%> (+3.22%) ⬆️
.../components/menu/src/children/menu-sub/MenuSub.tsx 97.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1592ea2...04228bd. Read the comment docs.

@danranVm danranVm merged commit f88ca6d into IDuxFE:main Jan 14, 2022
@danranVm danranVm deleted the refactor-menus branch January 14, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant