Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pro:layout): suppor all slots of IxMenu #738

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Jan 24, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Jan 24, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #738 (7025c0f) into main (8365e82) will decrease coverage by 0.01%.
The diff coverage is 80.64%.

❗ Current head 7025c0f differs from pull request most recent head 09e7228. Consider uploading reports for the commit 09e7228 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   85.44%   85.43%   -0.02%     
==========================================
  Files         421      421              
  Lines       10682    10681       -1     
  Branches     2511     2510       -1     
==========================================
- Hits         9127     9125       -2     
- Misses       1555     1556       +1     
Impacted Files Coverage Δ
packages/components/menu/src/Menu.tsx 100.00% <ø> (ø)
packages/components/menu/src/contents/MenuItem.tsx 96.77% <ø> (ø)
packages/components/menu/src/contents/Utils.tsx 90.90% <ø> (ø)
...nents/menu/src/contents/menu-sub/InlineContent.tsx 100.00% <ø> (ø)
...ents/menu/src/contents/menu-sub/OverlayContent.tsx 6.66% <ø> (ø)
packages/pro/layout/src/Layout.tsx 100.00% <ø> (ø)
packages/pro/layout/src/LayoutSiderTrigger.tsx 93.75% <ø> (ø)
...ackages/pro/layout/src/composables/useActiveKey.ts 91.66% <ø> (ø)
packages/pro/layout/src/token.ts 100.00% <ø> (ø)
packages/pro/layout/src/types.ts 66.66% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8365e82...09e7228. Read the comment docs.

@danranVm danranVm merged commit 9745c32 into IDuxFE:main Jan 24, 2022
@danranVm danranVm deleted the refactor-pro-layout branch January 24, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant