Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:divider): add size prop #742

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Jan 25, 2022

BREAKING CHANGE: position was deprecated, please use labelPlacement instead, type was
deprecated, please use vertical instead

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

BREAKING CHANGE: `position` was deprecated, please use `labelPlacement` instead, `type` was
deprecated, please use `vertical` instead
@idux-bot
Copy link

idux-bot bot commented Jan 25, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #742 (8a9f15e) into main (70a8f76) will decrease coverage by 0.00%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   83.25%   83.25%   -0.01%     
==========================================
  Files         461      461              
  Lines       12065    12070       +5     
  Branches     2860     2868       +8     
==========================================
+ Hits        10045    10049       +4     
- Misses       2020     2021       +1     
Impacted Files Coverage Δ
packages/components/config/src/defaultConfig.ts 100.00% <ø> (ø)
packages/components/divider/src/types.ts 100.00% <ø> (ø)
packages/components/utils/src/covertVNode.ts 85.00% <ø> (ø)
packages/components/divider/src/Divider.tsx 96.15% <95.23%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a8f76...8a9f15e. Read the comment docs.

@danranVm danranVm merged commit c6b4919 into IDuxFE:main Jan 25, 2022
@danranVm danranVm deleted the refactor-divider branch January 25, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant