Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:checkbox): use dataSource instead of options #753

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Feb 14, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #753 (610a958) into main (9a970de) will increase coverage by 0.00%.
The diff coverage is 89.18%.

❗ Current head 610a958 differs from pull request most recent head 6b5cff2. Consider uploading reports for the commit 6b5cff2 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #753   +/-   ##
=======================================
  Coverage   83.19%   83.19%           
=======================================
  Files         461      461           
  Lines       12067    12073    +6     
  Branches     2873     2875    +2     
=======================================
+ Hits        10039    10044    +5     
- Misses       2028     2029    +1     
Impacted Files Coverage Δ
packages/components/checkbox/index.ts 100.00% <ø> (ø)
packages/components/checkbox/src/types.ts 100.00% <ø> (ø)
packages/components/menu/src/contents/MenuItem.tsx 96.77% <ø> (ø)
...ges/components/menu/src/contents/MenuItemGroup.tsx 88.00% <ø> (ø)
...es/components/menu/src/contents/menu-sub/Label.tsx 89.74% <ø> (ø)
...ackages/components/select/src/trigger/Selector.tsx 96.22% <0.00%> (ø)
...ckages/components/table/src/main/body/BodyCell.tsx 82.55% <0.00%> (ø)
packages/components/checkbox/src/CheckboxGroup.tsx 94.73% <88.88%> (-5.27%) ⬇️
packages/components/checkbox/src/Checkbox.tsx 95.71% <100.00%> (+0.12%) ⬆️
packages/components/divider/src/Divider.tsx 96.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a970de...6b5cff2. Read the comment docs.

@danranVm danranVm merged commit ac2579a into IDuxFE:main Feb 15, 2022
@danranVm danranVm deleted the refactor-checkbox branch February 15, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant