Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:layoutpro): add siderHover and compress props #759

Merged
merged 3 commits into from
Feb 21, 2022

Conversation

typistZxd
Copy link
Member

@typistZxd typistZxd commented Feb 16, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

pro/layout组件功能支持

  • 支持hover侧边栏时展开
  • 支持hover时延迟展开
  • 支持侧边栏展开时悬浮在content之上

image

image

Other information

@idux-bot
Copy link

idux-bot bot commented Feb 16, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #759 (6b1df03) into main (c947a1f) will increase coverage by 0.00%.
The diff coverage is 87.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #759   +/-   ##
=======================================
  Coverage   83.17%   83.17%           
=======================================
  Files         464      464           
  Lines       12052    12082   +30     
  Branches     2871     2876    +5     
=======================================
+ Hits        10024    10049   +25     
- Misses       2028     2033    +5     
Impacted Files Coverage Δ
packages/pro/layout/src/token.ts 100.00% <ø> (ø)
packages/pro/layout/src/types.ts 66.66% <ø> (ø)
packages/pro/layout/src/Layout.tsx 90.90% <81.81%> (-9.10%) ⬇️
packages/pro/layout/src/contents/Sider.tsx 78.84% <87.50%> (+2.10%) ⬆️
packages/components/menu/src/Menu.tsx 100.00% <100.00%> (ø)
.../components/menu/src/composables/usePaddingLeft.ts 100.00% <100.00%> (ø)
packages/components/menu/src/contents/MenuItem.tsx 96.77% <100.00%> (ø)
...ges/components/menu/src/contents/MenuItemGroup.tsx 88.00% <100.00%> (ø)
.../components/menu/src/contents/menu-sub/MenuSub.tsx 97.01% <100.00%> (ø)
packages/pro/layout/src/LayoutSiderTrigger.tsx 94.44% <100.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c947a1f...6b1df03. Read the comment docs.

@typistZxd typistZxd force-pushed the feat-layoutPro-zxd branch 2 times, most recently from a0f32c1 to 5c911fc Compare February 18, 2022 01:33
packages/pro/layout/docs/Index.zh.md Outdated Show resolved Hide resolved
@typistZxd typistZxd changed the title feat(comp:layoutpro): add hoverTrigger and compress props feat(comp:layoutpro): add siderHover and compress props Feb 21, 2022
@danranVm danranVm merged commit faf0913 into IDuxFE:main Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants