Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(comp:form): api redesign and add test #763

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Feb 23, 2022

BREAKING CHANGE: hasFeedback was deprecated, please use statusIcon instead. extra was
deprecated, please use extraMessage instead.

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

BREAKING CHANGE: `hasFeedback` was deprecated, please use `statusIcon` instead.  `extra` was
deprecated, please use `extraMessage` instead.
@idux-bot
Copy link

idux-bot bot commented Feb 23, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #763 (d440fde) into main (c947a1f) will increase coverage by 0.81%.
The diff coverage is 88.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
+ Coverage   83.17%   83.99%   +0.81%     
==========================================
  Files         464      466       +2     
  Lines       12052    12100      +48     
  Branches     2871     2881      +10     
==========================================
+ Hits        10024    10163     +139     
+ Misses       2028     1937      -91     
Impacted Files Coverage Δ
packages/components/form/index.ts 100.00% <ø> (ø)
packages/components/form/src/token.ts 100.00% <ø> (+40.00%) ⬆️
packages/components/table/src/main/MainTable.tsx 67.56% <0.00%> (+1.77%) ⬆️
...ges/components/form/src/composables/useFormItem.ts 86.90% <86.90%> (ø)
packages/components/form/src/FormItem.tsx 98.00% <96.29%> (+72.13%) ⬆️
packages/components/form/src/Form.tsx 100.00% <100.00%> (+75.00%) ⬆️
packages/components/form/src/types.ts 100.00% <100.00%> (ø)
packages/pro/layout/src/Layout.tsx 90.90% <0.00%> (-9.10%) ⬇️
packages/components/table/src/main/body/Body.tsx 89.47% <0.00%> (-1.01%) ⬇️
packages/pro/layout/src/token.ts 100.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c947a1f...d440fde. Read the comment docs.

@danranVm danranVm merged commit 825066e into IDuxFE:main Feb 23, 2022
@danranVm danranVm deleted the refactor-form branch February 23, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant