Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(comp:select): api redesign #773

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

danranVm
Copy link
Member

BREAKING CHANGE: compareWith was deprecated, please use compareFn instead, options was deprecated, please use dataSource instead, searchFilter was deprecated, please use searchFn instead.

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

BREAKING CHANGE: `compareWith` was deprecated, please use `compareFn` instead, `options` was deprecated, please use `dataSource` instead, `searchFilter` was deprecated, please use `searchFn` instead.
@idux-bot
Copy link

idux-bot bot commented Feb 28, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #773 (f198b91) into main (25e85a3) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
- Coverage   83.89%   83.89%   -0.01%     
==========================================
  Files         465      465              
  Lines       12024    12033       +9     
  Branches     2874     2886      +12     
==========================================
+ Hits        10088    10095       +7     
- Misses       1936     1938       +2     
Impacted Files Coverage Δ
packages/components/select/src/content/ListBox.tsx 93.33% <66.66%> (-6.67%) ⬇️
...ponents/select/src/composables/useSelectedState.ts 81.57% <85.71%> (+1.02%) ⬆️
...es/components/select/src/composables/useOptions.ts 98.75% <92.85%> (-1.25%) ⬇️
...omponents/select/src/composables/useActiveState.ts 91.17% <100.00%> (+0.26%) ⬆️
packages/components/select/src/content/Option.tsx 100.00% <100.00%> (ø)
packages/components/select/src/trigger/Trigger.tsx 77.58% <100.00%> (ø)
packages/components/select/src/types.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e85a3...f198b91. Read the comment docs.

@danranVm danranVm merged commit 934c0b2 into IDuxFE:main Mar 1, 2022
@danranVm danranVm deleted the refactor-select branch March 1, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant