Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp: checkbox): onChange returned an error oldValue #792

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

liuzaijiang
Copy link
Contributor

fix #790

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Mar 9, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #792 (2c681a0) into main (3b8c9d9) will increase coverage by 0.00%.
The diff coverage is 94.73%.

❗ Current head 2c681a0 differs from pull request most recent head ff35406. Consider uploading reports for the commit ff35406 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #792   +/-   ##
=======================================
  Coverage   83.99%   83.99%           
=======================================
  Files         466      466           
  Lines       12026    12033    +7     
  Branches     2890     2893    +3     
=======================================
+ Hits        10101    10107    +6     
- Misses       1925     1926    +1     
Impacted Files Coverage Δ
packages/components/button/src/types.ts 100.00% <ø> (ø)
packages/components/config/src/defaultConfig.ts 100.00% <ø> (ø)
packages/components/menu/src/Menu.tsx 100.00% <ø> (ø)
packages/components/menu/src/token.ts 100.00% <ø> (ø)
.../components/menu/src/contents/menu-sub/MenuSub.tsx 95.58% <85.71%> (-1.43%) ⬇️
packages/components/button/src/Button.tsx 96.55% <100.00%> (+0.12%) ⬆️
packages/components/checkbox/src/Checkbox.tsx 95.83% <100.00%> (+0.11%) ⬆️
packages/components/menu/src/contents/MenuItem.tsx 96.87% <100.00%> (+0.10%) ⬆️
...ges/components/menu/src/contents/MenuItemGroup.tsx 88.46% <100.00%> (+0.46%) ⬆️
packages/components/stepper/src/Stepper.tsx 94.11% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b8c9d9...ff35406. Read the comment docs.

@danranVm danranVm merged commit 2825def into IDuxFE:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:checkbox] change 事件返回的 oldChecked 有误
2 participants