Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:menu): remove stopPropagation #799

Merged
merged 1 commit into from
Mar 12, 2022
Merged

Conversation

danranVm
Copy link
Member

fix #791

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Mar 11, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #799 (1e2540e) into main (57e88f0) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

❗ Current head 1e2540e differs from pull request most recent head a9c1650. Consider uploading reports for the commit a9c1650 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
- Coverage   84.00%   84.00%   -0.01%     
==========================================
  Files         466      466              
  Lines       12036    12033       -3     
  Branches     2895     2894       -1     
==========================================
- Hits        10111    10108       -3     
  Misses       1925     1925              
Impacted Files Coverage Δ
packages/components/menu/src/contents/MenuItem.tsx 96.77% <ø> (-0.11%) ⬇️
...ges/components/menu/src/contents/MenuItemGroup.tsx 92.00% <ø> (+3.53%) ⬆️
.../components/menu/src/contents/menu-sub/MenuSub.tsx 95.31% <ø> (-0.28%) ⬇️
packages/components/menu/src/token.ts 100.00% <ø> (ø)
...es/components/menu/src/contents/menu-sub/Label.tsx 88.09% <83.33%> (-1.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e88f0...a9c1650. Read the comment docs.

@danranVm danranVm merged commit fedf778 into IDuxFE:main Mar 12, 2022
@danranVm danranVm deleted the fix-menu branch March 18, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:menu] menu组件不应该将click事件阻止冒泡
1 participant