Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:select): disable option when limited #804

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Mar 17, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #804 (c8a0ee1) into main (eca22cf) will increase coverage by 0.03%.
The diff coverage is 81.25%.

❗ Current head c8a0ee1 differs from pull request most recent head 41d2d6a. Consider uploading reports for the commit 41d2d6a to get more accurate results

@@            Coverage Diff             @@
##             main     #804      +/-   ##
==========================================
+ Coverage   84.00%   84.03%   +0.03%     
==========================================
  Files         466      466              
  Lines       12038    12043       +5     
  Branches     2898     2897       -1     
==========================================
+ Hits        10112    10120       +8     
+ Misses       1926     1923       -3     
Impacted Files Coverage Δ
packages/components/locales/src/langs/en-US.ts 100.00% <ø> (ø)
packages/components/locales/src/langs/zh-CN.ts 100.00% <ø> (ø)
...ponents/select/src/composables/useSelectedState.ts 90.24% <75.00%> (+8.66%) ⬆️
packages/components/select/src/Select.tsx 93.75% <100.00%> (+0.13%) ⬆️
packages/components/select/src/content/Option.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8677d61...41d2d6a. Read the comment docs.

@danranVm danranVm merged commit aa6a5aa into IDuxFE:main Mar 17, 2022
@danranVm danranVm deleted the fix-select branch March 17, 2022 12:01
danranVm added a commit to danranVm/idux that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant