Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp: select): maxLabel support responsive #806

Merged
merged 2 commits into from
Mar 20, 2022
Merged

feat(comp: select): maxLabel support responsive #806

merged 2 commits into from
Mar 20, 2022

Conversation

hangboss1761
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

#756

What is the new behavior?

#756

Other information

@idux-bot
Copy link

idux-bot bot commented Mar 18, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #806 (189d803) into main (48bacb2) will increase coverage by 0.46%.
The diff coverage is 87.09%.

@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
+ Coverage   84.41%   84.88%   +0.46%     
==========================================
  Files         467      493      +26     
  Lines       12034    12711     +677     
  Branches     2891     3058     +167     
==========================================
+ Hits        10159    10790     +631     
- Misses       1875     1921      +46     
Impacted Files Coverage Δ
packages/components/select/src/trigger/Item.tsx 77.77% <0.00%> (ø)
packages/components/select/src/types.ts 100.00% <ø> (ø)
...ackages/components/select/src/trigger/Selector.tsx 91.66% <82.60%> (-4.70%) ⬇️
...ages/components/_private/overflow/src/Overflow.tsx 87.35% <87.35%> (ø)
packages/cdk/utils/src/props.ts 77.41% <100.00%> (ø)
packages/components/_private/overflow/index.ts 100.00% <100.00%> (ø)
packages/components/_private/overflow/src/Item.tsx 100.00% <100.00%> (ø)
packages/components/_private/overflow/src/types.ts 100.00% <100.00%> (ø)
packages/components/icon/src/definitions.ts 100.00% <0.00%> (ø)
packages/components/icon/src/dependencies.ts 100.00% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48bacb2...189d803. Read the comment docs.

packages/components/_private/overflow/index.ts Outdated Show resolved Hide resolved
packages/components/_private/overflow/index.ts Outdated Show resolved Hide resolved
packages/components/_private/overflow/src/types.ts Outdated Show resolved Hide resolved
packages/components/_private/overflow/src/types.ts Outdated Show resolved Hide resolved
packages/components/_private/overflow/src/Item.tsx Outdated Show resolved Hide resolved
packages/components/select/demo/MaxLabelCount.vue Outdated Show resolved Hide resolved
packages/components/select/demo/MaxLabelCount.vue Outdated Show resolved Hide resolved
packages/components/select/src/types.ts Outdated Show resolved Hide resolved
packages/components/select/src/trigger/Selector.tsx Outdated Show resolved Hide resolved
@danranVm danranVm changed the title Feat/select max label count responsive feat(comp: select): maxLabel support responsive Mar 20, 2022
@danranVm danranVm merged commit 115b5ec into IDuxFE:main Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants