Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pro:transfer): add pro transfer compoennt #815

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

sallerli1
Copy link
Contributor

add table and tree transfer

feat(comp:tree): modify tree disabled logic
node disabled property and disabled function is now combined

fix(comp:transfer): fix transfer select disabled status
selection is not disabled now when the item is disabled

fix(comp:transfer): transfer triggers now filter out disabled items

docs(comp:transfer): modify transfer docs

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

添加ProTransfer: 表格穿梭框以及树穿梭框
修改tree组件禁用逻辑
修改穿梭框勾选项的禁用逻辑,避免勾选状态变为非受控状态以及影响勾选状态的正确计算
修改基础穿梭框文档

Other information

@idux-bot
Copy link

idux-bot bot commented Mar 22, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #815 (ed519df) into main (3b99839) will increase coverage by 0.26%.
The diff coverage is 91.03%.

❗ Current head ed519df differs from pull request most recent head 2317753. Consider uploading reports for the commit 2317753 to get more accurate results

@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
+ Coverage   85.39%   85.65%   +0.26%     
==========================================
  Files         493      507      +14     
  Lines       12728    13087     +359     
  Branches     3069     3165      +96     
==========================================
+ Hits        10869    11210     +341     
- Misses       1859     1876      +17     
- Partials        0        1       +1     
Impacted Files Coverage Δ
packages/components/transfer/index.ts 100.00% <ø> (ø)
packages/components/transfer/src/types.ts 100.00% <ø> (ø)
...ckages/components/tree-select/src/trigger/Item.tsx 80.00% <0.00%> (ø)
packages/components/tree-select/src/types.ts 66.66% <ø> (ø)
packages/components/transfer/src/Transfer.tsx 96.15% <50.00%> (+5.52%) ⬆️
.../transfer/src/composables/useTransferTableProps.ts 77.35% <77.35%> (ø)
packages/pro/transfer/src/types.ts 80.00% <80.00%> (ø)
...o/transfer/src/composables/useTransferTreeProps.ts 88.23% <88.23%> (ø)
...ro/transfer/src/composables/useTreeExpandedKeys.ts 88.46% <88.46%> (ø)
...kages/pro/transfer/src/content/ProTransferList.tsx 90.00% <90.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b99839...2317753. Read the comment docs.

@sallerli1 sallerli1 force-pushed the feat-pro-transfer-saller branch 3 times, most recently from 6751d8d to ede5294 Compare March 24, 2022 11:40
Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档和 types 没有对应,需要再次检查一下。

add table and tree transfer

feat(comp:tree): modify tree disabled logic
node disabled property and disabled function is now combined

fix(comp:transfer): fix transfer select disabled status
selection is not disabled now when the item is disabled

fix(comp:transfer): transfer triggers now filter out disabled items

docs(comp:transfer): modify transfer docs
@danranVm danranVm merged commit e367009 into IDuxFE:main Mar 25, 2022
@sallerli1 sallerli1 deleted the feat-pro-transfer-saller branch February 20, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants