Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:table): support autoHeight #816

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Mar 22, 2022

fix #757

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Mar 22, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #816 (484d40a) into main (11974d2) will increase coverage by 0.55%.
The diff coverage is 100.00%.

❗ Current head 484d40a differs from pull request most recent head 182a694. Consider uploading reports for the commit 182a694 to get more accurate results

@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
+ Coverage   84.88%   85.43%   +0.55%     
==========================================
  Files         493      493              
  Lines       12711    12725      +14     
  Branches     3058     3068      +10     
==========================================
+ Hits        10790    10872      +82     
+ Misses       1921     1853      -68     
Impacted Files Coverage Δ
packages/components/config/src/defaultConfig.ts 100.00% <ø> (ø)
packages/components/table/src/types.ts 80.00% <ø> (ø)
...ackages/components/select/src/trigger/Selector.tsx 93.22% <100.00%> (+1.55%) ⬆️
packages/components/table/src/Table.tsx 100.00% <100.00%> (ø)
...ages/components/table/src/composables/useScroll.ts 88.70% <100.00%> (+0.37%) ⬆️
packages/components/table/src/main/FixedHolder.tsx 83.87% <100.00%> (+74.19%) ⬆️
...ges/components/table/src/composables/useColumns.ts 71.91% <0.00%> (+2.24%) ⬆️
packages/components/table/src/main/MainTable.tsx 74.32% <0.00%> (+6.75%) ⬆️
packages/cdk/utils/src/dom.ts 83.95% <0.00%> (+7.40%) ⬆️
packages/components/table/src/main/ColGroup.tsx 100.00% <0.00%> (+13.04%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11974d2...182a694. Read the comment docs.

@danranVm danranVm merged commit 7a87569 into IDuxFE:main Mar 22, 2022
@danranVm danranVm deleted the feat-table-auto-height branch March 22, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:table] 表格实现撑满页面时,内容区自动计算高度进行滚动
1 participant