Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:comment): add comment component #822

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

thinkingOfBetty
Copy link
Contributor

@thinkingOfBetty thinkingOfBetty commented Mar 24, 2022

fix #358

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Mar 24, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #822 (7ccc3c8) into main (11974d2) will increase coverage by 0.80%.
The diff coverage is 91.71%.

❗ Current head 7ccc3c8 differs from pull request most recent head 0c4056f. Consider uploading reports for the commit 0c4056f to get more accurate results

@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
+ Coverage   84.88%   85.69%   +0.80%     
==========================================
  Files         493      509      +16     
  Lines       12711    13122     +411     
  Branches     3058     3178     +120     
==========================================
+ Hits        10790    11245     +455     
+ Misses       1921     1876      -45     
- Partials        0        1       +1     
Impacted Files Coverage Δ
packages/cdk/scroll/src/virtual/types.ts 50.00% <ø> (ø)
packages/components/config/src/defaultConfig.ts 100.00% <ø> (ø)
packages/components/select/src/content/Content.tsx 86.36% <ø> (ø)
packages/components/select/src/trigger/Input.tsx 100.00% <ø> (ø)
packages/components/select/src/types.ts 100.00% <ø> (ø)
packages/components/slider/src/useSlider.ts 57.69% <0.00%> (ø)
packages/components/table/src/main/body/Body.tsx 89.47% <ø> (ø)
packages/components/table/src/types.ts 80.00% <ø> (ø)
packages/components/timeline/src/token.ts 100.00% <ø> (ø)
packages/components/transfer/index.ts 100.00% <ø> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11974d2...0c4056f. Read the comment docs.

Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有些代码风格建议优化一下。

packages/components/comment/src/Comment.tsx Outdated Show resolved Hide resolved
packages/components/comment/src/Comment.tsx Outdated Show resolved Hide resolved
packages/components/comment/src/Comment.tsx Outdated Show resolved Hide resolved
packages/components/comment/src/Comment.tsx Outdated Show resolved Hide resolved
packages/components/comment/docs/Design.zh.md Outdated Show resolved Hide resolved
packages/components/comment/docs/Index.zh.md Outdated Show resolved Hide resolved
packages/components/comment/demo/Basic.vue Outdated Show resolved Hide resolved
Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danranVm danranVm merged commit e3f1e98 into IDuxFE:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp: comment] add comment component
2 participants