Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:select): support setting autocomplete #833

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Apr 2, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Apr 2, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #833 (aa98a77) into main (26f732b) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##             main     #833   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files         511      511           
  Lines       13115    13117    +2     
  Branches     2871     2872    +1     
=======================================
+ Hits        11247    11249    +2     
  Misses       1867     1867           
  Partials        1        1           
Impacted Files Coverage Δ
packages/components/_private/overlay/src/types.ts 100.00% <ø> (ø)
...components/_private/selector/src/contents/Item.tsx 77.77% <0.00%> (ø)
packages/components/_private/selector/src/types.ts 100.00% <ø> (ø)
packages/components/select/src/Select.tsx 78.26% <ø> (ø)
packages/components/select/src/types.ts 100.00% <ø> (ø)
packages/components/time-picker/src/TimePicker.tsx 10.34% <0.00%> (ø)
...ckages/components/_private/overlay/src/Overlay.tsx 96.42% <100.00%> (+0.13%) ⬆️
...ages/components/_private/selector/src/Selector.tsx 95.06% <100.00%> (ø)
...omponents/_private/selector/src/contents/Input.tsx 100.00% <100.00%> (ø)
packages/components/date-picker/src/DatePicker.tsx 89.47% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f732b...aa98a77. Read the comment docs.

@danranVm danranVm merged commit 583952d into IDuxFE:main Apr 2, 2022
@danranVm danranVm deleted the refactor-tree-select branch April 2, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant