feat(comp:tag-group): add tagGroup component #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
brenner8023
force-pushed
the
feat-taggroup
branch
from
92a9364
to
b138268
Compare
Codecov Report
@@ Coverage Diff @@
## main #836 +/- ##
==========================================
+ Coverage 93.26% 93.28% +0.02%
==========================================
Files 633 635 +2
Lines 60502 60758 +256
Branches 7229 7266 +37
==========================================
+ Hits 56426 56681 +255
- Misses 4076 4077 +1
Continue to review full report at Codecov.
|
brenner8023
force-pushed
the
feat-taggroup
branch
from
b138268
to
e346b13
Compare
danranVm
requested changes
Apr 8, 2022
brenner8023
force-pushed
the
feat-taggroup
branch
from
e346b13
to
575bde5
Compare
danranVm
requested changes
Apr 9, 2022
|
|
||
| import { type TagGapSize, tagGroupProps } from './types' | ||
|
|
||
| const defaultGapMap = { |
There was a problem hiding this comment.
这个干掉吧，这种只给一个 number 或者 string 的类型就算了，不给这种预设的值了。
| @@ -271,6 +271,10 @@ export const defaultConfig: GlobalConfig = { | |||
| }, | |||
| }, | |||
| tag: {}, | |||
| tagGroup: { | |||
| gap: 'sm', | |||
There was a problem hiding this comment.
Suggested change
| gap: 'sm', | |
| gap: 8, |
| @@ -417,6 +418,11 @@ export interface TagConfig { | |||
| shape?: TagShape | |||
| } | |||
|
|
|||
| export interface TagGroupConfig { | |||
| gap: number | [number | string, number | string] | TagGapSize | |||
There was a problem hiding this comment.
Suggested change
| gap: number | [number | string, number | string] | TagGapSize | |
| gap: number | string |
packages/components/tag/src/types.ts
Outdated
| closable: IxPropTypes.bool.def(false), | ||
| closeIcon: IxPropTypes.string.def('close'), | ||
| dataSource: IxPropTypes.array<TagData>(), | ||
| gap: IxPropTypes.oneOfType([Number, String, IxPropTypes.array<string | number>()]), |
There was a problem hiding this comment.
Suggested change
| gap: IxPropTypes.oneOfType([Number, String, IxPropTypes.array<string | number>()]), | |
| gap: IxPropTypes.oneOfType([Number, String), |
简单一点，不需要支持纵向的场景。
|
另外需要修改一下 test， 切换到 vitest 了。 |
brenner8023
force-pushed
the
feat-taggroup
branch
2 times, most recently
from
a6dacf6
to
7730a98
Compare
brenner8023
force-pushed
the
feat-taggroup
branch
from
7730a98
to
0481e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #826
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Other information