feat(comp:date-picker): add datetime type, add dateRangePicker #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 93.29% 93.72% +0.43%
==========================================
Files 633 649 +16
Lines 60449 62992 +2543
Branches 7234 7601 +367
==========================================
+ Hits 56393 59037 +2644
+ Misses 4056 3955 -101
Continue to review full report at Codecov.
|
sallerli1
force-pushed
the
feat-date-time-picker-saller
branch
2 times, most recently
from
6362dae
to
ac7d73f
Compare
sallerli1
changed the title
sallerli1
force-pushed
the
feat-date-time-picker-saller
branch
from
ac7d73f
to
f2e05b4
Compare
danranVm
requested changes
Apr 13, 2022
| | `placeholder` | 选择框默认文本 | `string \| #placeholder` | - | - | 可以通过国际化配置默认值 | | ||
| | `timePicker` | 是否显示时间选择器 | `boolean \| TimePickerProps` | `false` | - | 仅在 `type='date'` 时生效 | | ||
| | `timePanelProps` | 时间选择器props | `TimePanelProps` | `false` | - | 仅在 `type='datetime'` 时生效 | |
There was a problem hiding this comment.
这个改回 timePicker 吧，其他组件都是不带 props 后缀的。
| | `placeholder` | 选择框默认文本 | `string[] \| #placeholder=placement:'start'\|'end'` | - | - | 默认使用 `i18n` 配置 | | ||
| | `separator` | 自定义分隔符图标 | `string \| VNode \| #separator` | `'swap-right'` | ✅ | - | | ||
| | `timePicker` | 是否显示时间选择器 | `boolean \| TimePickerProps \| TimePickerProps[]` | `false` | - | 如果需要对前后的时间选择器配置不同的禁用条件，可以传入一个数组 | | ||
| | `timePanelProps` | 是否显示时间选择器 | `TimePanelProps \| TimePanelProps[]` | `false` | - | 如果需要对前后的时间选择器配置不同的禁用条件，可以传入一个数组 | |
|
danranVm
requested changes
Apr 13, 2022
| const prefixCls = mergedPrefixCls.value | ||
|
|
||
| return ( | ||
| <div ref={triggerRef} class={classes.value} onClick={handleClick} onKeydown={handleKeyDown}> | ||
| <ɵTrigger class={prefixCls} v-slots={slots} {...triggerProps.value}> |
There was a problem hiding this comment.
Suggested change
| <ɵTrigger class={prefixCls} v-slots={slots} {...triggerProps.value}> | |
| <ɵTrigger className={prefixCls} v-slots={slots} {...triggerProps.value}> |
sallerli1
force-pushed
the
feat-date-time-picker-saller
branch
2 times, most recently
from
d960212
to
91ff0c5
Compare
feat(comp:date-picker): add dateRangePicker component feat(comp:date-picker): remove week prefix according to ui fix(comp:time-picker): fix time-picker scroll problem occured under PM fix(comp:table): fix typescript type error doc(comp:all): update less variable in documents
sallerli1
force-pushed
the
feat-date-time-picker-saller
branch
from
91ff0c5
to
efa6ad4
Compare
danranVm
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add datetime pick functionality
feat(comp:date-range-picker): add dateRangePicker
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
新增 datetime 类型，同时选择日期与时间
新增日期范围选择，类型与日期选择一致
修改日期选择面板样式
修改week类型面板样式与视觉稿一致
新增日期范围选择 DateRangePicker
Other information