Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:input): update style with selector #842

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Apr 9, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Apr 9, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #842 (96df33f) into main (30261bb) will decrease coverage by 0.00%.
The diff coverage is 92.42%.

❗ Current head 96df33f differs from pull request most recent head 13d2b77. Consider uploading reports for the commit 13d2b77 to get more accurate results

@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
- Coverage   93.26%   93.26%   -0.01%     
==========================================
  Files         633      633              
  Lines       60466    60502      +36     
  Branches     7228     7229       +1     
==========================================
+ Hits        56396    56426      +30     
- Misses       4070     4076       +6     
Impacted Files Coverage Δ
packages/components/select/src/content/Content.tsx 77.88% <44.44%> (-1.92%) ⬇️
packages/components/_private/input/src/Input.tsx 100.00% <100.00%> (ø)
...ages/components/_private/selector/src/Selector.tsx 97.04% <100.00%> (+0.21%) ⬆️
packages/components/_private/selector/src/types.ts 100.00% <100.00%> (ø)
packages/components/select/src/Select.tsx 93.83% <100.00%> (+0.02%) ⬆️
packages/components/tree-select/src/TreeSelect.tsx 98.91% <100.00%> (+<0.01%) ⬆️
...ges/components/tree-select/src/content/Content.tsx 89.45% <100.00%> (+0.18%) ⬆️
packages/components/tree-select/src/types.ts 99.25% <100.00%> (ø)
packages/components/icon/src/utils.ts 72.25% <0.00%> (-1.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30261bb...13d2b77. Read the comment docs.

@danranVm danranVm merged commit 39239be into IDuxFE:main Apr 9, 2022
@danranVm danranVm deleted the fix-private-input branch April 9, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants