Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp: select): sync width on opened #853

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Apr 21, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #853 (fd01c51) into main (24f173e) will decrease coverage by 0.03%.
The diff coverage is 94.91%.

@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   93.65%   93.62%   -0.04%     
==========================================
  Files         647      647              
  Lines       62759    62949     +190     
  Branches     7571     7678     +107     
==========================================
+ Hits        58776    58934     +158     
- Misses       3983     4015      +32     
Impacted Files Coverage Δ
...mponents/select/src/composables/useOverlayState.ts 95.16% <89.28%> (+2.85%) ⬆️
packages/cdk/scroll/src/virtual/types.ts 100.00% <100.00%> (ø)
...ages/components/_private/selector/src/Selector.tsx 99.15% <100.00%> (+0.01%) ⬆️
packages/components/_private/selector/src/types.ts 100.00% <100.00%> (ø)
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
packages/components/select/src/Select.tsx 93.95% <100.00%> (+0.11%) ⬆️
packages/components/select/src/types.ts 99.37% <100.00%> (+<0.01%) ⬆️
packages/components/tree-select/src/TreeSelect.tsx 98.93% <100.00%> (+0.02%) ⬆️
packages/components/tree-select/src/types.ts 99.25% <100.00%> (+<0.01%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f173e...fd01c51. Read the comment docs.

@danranVm danranVm changed the base branch from main to hotfix April 21, 2022 01:35
@danranVm danranVm merged commit 7b40e6f into IDuxFE:hotfix Apr 21, 2022
@danranVm danranVm deleted the fix-select-overlay-width-1 branch April 21, 2022 01:35
danranVm added a commit that referenced this pull request Apr 21, 2022
sallerli1 pushed a commit to sallerli1/idux that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant