Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp: menu): add customAdditional, getKey and overlayContainer #871

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

danranVm
Copy link
Member

BREAKING CHANGE: dataSource.additional was deprecated, please use customAdditional instead. target was deprecated, please use overlayContainer instead.

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

BREAKING CHANGE: `dataSource.additional` was deprecated, please use `customAdditional` instead. `target` was deprecated, please use `overlayContainer` instead.
@idux-bot
Copy link

idux-bot bot commented Apr 29, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #871 (62eaccc) into main (593f86f) will increase coverage by 0.00%.
The diff coverage is 97.07%.

@@           Coverage Diff            @@
##             main     #871    +/-   ##
========================================
  Coverage   93.45%   93.46%            
========================================
  Files         657      657            
  Lines       64760    64939   +179     
  Branches     7847     7864    +17     
========================================
+ Hits        60522    60694   +172     
- Misses       4238     4245     +7     
Impacted Files Coverage Δ
packages/components/dropdown/src/Dropdown.tsx 33.80% <0.00%> (-2.57%) ⬇️
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
packages/components/dropdown/src/types.ts 100.00% <100.00%> (ø)
packages/components/menu/index.ts 97.29% <100.00%> (+0.07%) ⬆️
packages/components/menu/src/Menu.tsx 100.00% <100.00%> (ø)
...kages/components/menu/src/contents/MenuDivider.tsx 100.00% <100.00%> (ø)
packages/components/menu/src/contents/MenuItem.tsx 94.94% <100.00%> (+0.63%) ⬆️
...ges/components/menu/src/contents/MenuItemGroup.tsx 91.35% <100.00%> (+1.21%) ⬆️
packages/components/menu/src/contents/Utils.tsx 93.10% <100.00%> (+0.24%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 593f86f...62eaccc. Read the comment docs.

@danranVm danranVm merged commit 5064add into IDuxFE:main Apr 29, 2022
@danranVm danranVm deleted the refactor-menu branch April 29, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant