Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp: alert): align icon with text #881

Merged
merged 1 commit into from
May 5, 2022

Conversation

liuzaijiang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented May 5, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #881 (ce4e021) into main (d10f5e0) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #881      +/-   ##
==========================================
- Coverage   93.50%   93.45%   -0.05%     
==========================================
  Files         657      657              
  Lines       64594    64954     +360     
  Branches     7845     7821      -24     
==========================================
+ Hits        60396    60706     +310     
- Misses       4198     4248      +50     
Impacted Files Coverage Δ
...nents/cascader/src/contents/OverlayOptionGroup.tsx 72.41% <0.00%> (-24.02%) ⬇️
...mponents/cascader/src/composables/useSearchable.ts 46.80% <0.00%> (-8.20%) ⬇️
packages/components/checkbox/src/CheckboxGroup.tsx 92.42% <0.00%> (-3.94%) ⬇️
packages/components/menu/src/contents/Utils.tsx 89.65% <0.00%> (-3.21%) ⬇️
packages/cdk/a11y/src/focusMonitor.ts 90.38% <0.00%> (-2.80%) ⬇️
...ges/components/tree-select/src/content/Content.tsx 86.63% <0.00%> (-2.73%) ⬇️
packages/components/dropdown/src/Dropdown.tsx 33.80% <0.00%> (-2.57%) ⬇️
packages/pro/layout/src/Layout.tsx 94.40% <0.00%> (-2.40%) ⬇️
packages/components/date-picker/src/DatePicker.tsx 95.04% <0.00%> (-1.99%) ⬇️
...ges/components/date-picker/src/DateRangePicker.tsx 93.85% <0.00%> (-1.76%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10f5e0...ce4e021. Read the comment docs.

@danranVm danranVm merged commit 4b4f567 into IDuxFE:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants