Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(comp:time-picker,date-picker): refactor #886

Merged
merged 1 commit into from
May 9, 2022

Conversation

sallerli1
Copy link
Contributor

@sallerli1 sallerli1 commented May 6, 2022

  1. refactor DateRangePicker activeDate control logic
  2. refactor DateRangePicker input logic
  3. unify DatePicker and TimePicker style variables
  4. unify DatePicker and TimePicker code structure

feat(comp:time-panel): add activeValue prop

fix(comp:date-picker,time-picker): fix overlay z-index error

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

  1. 时间选择代码结构与日期选择不一致
  2. 时间选择样式变量与日期选择不一致
  3. 时间选择defaultOpened与交互不一致
  4. 时间选择滚动触发区域太小
  5. 日期选择与时间选择z-index不正常

What is the new behavior?

  1. 统一代码结构与变量
  2. 时间选择的defaultOpenValue会定位到指定的数字上,但不会选中,默认为当前时间
  3. 时间选择滚动触发区域不留白
  4. 将z-index的样式绑定到最外层overlay,而不是内层content

Other information

fix issue #829
fix issue #880

@idux-bot
Copy link

idux-bot bot commented May 6, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #886 (73ac662) into main (44c67aa) will increase coverage by 0.00%.
The diff coverage is 61.94%.

@@           Coverage Diff            @@
##             main     #886    +/-   ##
========================================
  Coverage   93.46%   93.47%            
========================================
  Files         657      665     +8     
  Lines       65007    65298   +291     
  Branches     7823     7872    +49     
========================================
+ Hits        60759    61037   +278     
- Misses       4248     4261    +13     
Impacted Files Coverage Δ
...s/_private/date-panel/src/panel-body/PanelCell.tsx 97.67% <ø> (-0.06%) ⬇️
packages/components/config/src/defaultConfig.ts 100.00% <ø> (ø)
...s/date-picker/src/composables/useKeyboardEvents.ts 51.21% <0.00%> (-2.27%) ⬇️
packages/components/time-picker/src/utils.ts 37.14% <14.28%> (-15.24%) ⬇️
...ges/components/time-picker/src/trigger/Trigger.tsx 28.57% <16.66%> (+3.57%) ⬆️
packages/components/time-picker/src/TimePicker.tsx 31.25% <18.86%> (+1.54%) ⬆️
...ges/components/time-picker/src/content/Content.tsx 20.00% <20.00%> (ø)
...nts/time-picker/src/composables/useTriggerProps.ts 25.45% <25.45%> (ø)
...s/time-picker/src/composables/useKeyboardEvents.ts 29.26% <29.26%> (ø)
...mponents/time-picker/src/composables/useControl.ts 33.62% <33.62%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c67aa...73ac662. Read the comment docs.

@sallerli1 sallerli1 force-pushed the refactor-time-picker-saller branch 2 times, most recently from 69b9f4a to b37ad59 Compare May 7, 2022 07:10
1. refactor DateRangePicker activeDate control logic
2. refactor DateRangePicker input logic
3. unify DatePicker and TimePicker style variables
4. unify DatePicker and TimePicker code structure

feat(comp:time-panel): add activeValue prop

fix(comp:date-picker,time-picker): fix overlay z-index error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants