Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:select): value key of select is 'value' by default #892

Merged
merged 1 commit into from
May 9, 2022

Conversation

threedayAAAAA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented May 8, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #892 (a76d60f) into main (84e8e17) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #892   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         657      657           
  Lines       65008    65025   +17     
  Branches     7822     7823    +1     
=======================================
+ Hits        60760    60777   +17     
  Misses       4248     4248           
Impacted Files Coverage Δ
...ackages/components/select/__tests__/select.spec.ts 100.00% <100.00%> (ø)
...mponents/select/src/composables/useGetOptionKey.ts 92.68% <100.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84e8e17...a76d60f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants