Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp: table): update style with sticky and bodered #898

Merged
merged 2 commits into from
May 11, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented May 10, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

  • 修复了开启 sticky 不生效的样式问题
  • 修复了 boderless=false 时,表头分组的样式问题

Other information

@idux-bot
Copy link

idux-bot bot commented May 10, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #898 (9c249af) into main (9ba3eca) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   93.27%   93.27%   -0.01%     
==========================================
  Files         668      668              
  Lines       65741    65739       -2     
  Branches     7869     7869              
==========================================
- Hits        61321    61319       -2     
  Misses       4420     4420              
Impacted Files Coverage Δ
packages/components/table/src/Table.tsx 100.00% <100.00%> (ø)
packages/components/table/src/main/FixedHolder.tsx 90.24% <100.00%> (-0.46%) ⬇️
packages/components/table/src/main/MainTable.tsx 88.74% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba3eca...9c249af. Read the comment docs.

@danranVm danranVm merged commit ff75f3e into IDuxFE:main May 11, 2022
@danranVm danranVm deleted the feat-table-sticky branch May 11, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant