Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp: select): Add number to the type of label #901

Merged
merged 1 commit into from
May 12, 2022

Conversation

liuzaijiang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

在分页组件中
image

What is the new behavior?

无告警错误

Other information

@idux-bot
Copy link

idux-bot bot commented May 11, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #901 (9403c0d) into main (e9bb42b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #901   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files         673      673           
  Lines       66281    66281           
  Branches     7910     7911    +1     
=======================================
  Hits        62006    62006           
  Misses       4275     4275           
Impacted Files Coverage Δ
packages/components/select/src/types.ts 99.48% <100.00%> (ø)
packages/pro/tree/src/types.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9bb42b...9403c0d. Read the comment docs.

packages/components/select/src/types.ts Outdated Show resolved Hide resolved
packages/components/select/src/types.ts Outdated Show resolved Hide resolved
@liuzaijiang liuzaijiang changed the title fix(comp: select): Add string to the type of label fix(comp: select): Add number to the type of label May 12, 2022
@danranVm danranVm merged commit 5875e2d into IDuxFE:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants