Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp: select): search error when group exists #908

Merged
merged 1 commit into from
May 17, 2022

Conversation

liuzaijiang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

当存在分组情况时,搜索分组标题
Snipaste_2022-05-16_19-13-38

What is the new behavior?

Snipaste_2022-05-16_19-19-02

Other information

修复输入时,样式抖动
GIF 2022-5-16 19-21-31

@idux-bot
Copy link

idux-bot bot commented May 16, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #908 (101f0f4) into main (e9bb42b) will decrease coverage by 0.07%.
The diff coverage is 60.95%.

❗ Current head 101f0f4 differs from pull request most recent head e34542e. Consider uploading reports for the commit e34542e to get more accurate results

@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
- Coverage   93.55%   93.47%   -0.08%     
==========================================
  Files         673      674       +1     
  Lines       66281    66414     +133     
  Branches     7910     7916       +6     
==========================================
+ Hits        62006    62082      +76     
- Misses       4275     4332      +57     
Impacted Files Coverage Δ
...vate/time-panel/src/composables/useColumnEvents.ts 36.78% <36.78%> (ø)
...onents/_private/time-panel/src/TimePanelColumn.tsx 96.87% <85.71%> (-3.13%) ⬇️
...te/time-panel/__tests__/timeSelectorColumn.spec.ts 100.00% <100.00%> (ø)
...mponents/_private/time-panel/src/TimePanelCell.tsx 100.00% <100.00%> (ø)
...ackages/components/select/__tests__/select.spec.ts 100.00% <100.00%> (ø)
...es/components/select/src/composables/useOptions.ts 97.74% <100.00%> (+0.10%) ⬆️
packages/components/select/src/types.ts 99.48% <100.00%> (ø)
packages/pro/tree/src/types.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5875e2d...e34542e. Read the comment docs.

@danranVm danranVm merged commit ddbfc5e into IDuxFE:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants