Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk: resize): add useResizeObserver and CdkResizeObserver #909

Merged
merged 1 commit into from
May 17, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented May 16, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented May 16, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #909 (d8b59cb) into main (80dc256) will decrease coverage by 0.05%.
The diff coverage is 82.86%.

@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
- Coverage   93.47%   93.42%   -0.06%     
==========================================
  Files         674      679       +5     
  Lines       66381    66481     +100     
  Branches     7913     7904       -9     
==========================================
+ Hits        62049    62108      +59     
- Misses       4332     4373      +41     
Impacted Files Coverage Δ
packages/cdk/utils/src/dom.ts 83.87% <ø> (-2.43%) ⬇️
packages/cdk/resize/src/ResizeObserver.tsx 34.54% <34.54%> (ø)
packages/cdk/resize/src/utils.ts 91.48% <91.48%> (ø)
packages/cdk/resize/src/useResizeObserver.ts 95.12% <95.12%> (ø)
packages/cdk/resize/index.ts 95.65% <95.65%> (ø)
packages/cdk/a11y/src/focusMonitor.ts 90.38% <100.00%> (ø)
packages/cdk/resize/src/types.ts 100.00% <100.00%> (ø)
...ackages/cdk/scroll/src/virtual/contents/Holder.tsx 95.34% <100.00%> (ø)
packages/cdk/utils/src/convert.ts 100.00% <100.00%> (ø)
packages/components/_private/overflow/src/Item.tsx 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80dc256...d8b59cb. Read the comment docs.

@danranVm danranVm merged commit c20fe45 into IDuxFE:main May 17, 2022
@danranVm danranVm deleted the feat-cdk-resize branch May 17, 2022 01:31
@danranVm danranVm mentioned this pull request May 26, 2022
95 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant