Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp: table): controled filter works #919

Merged
merged 2 commits into from
May 19, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

排序无法受控,跟 #915 一样的问题。

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented May 19, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #919 (e8e7282) into main (a407920) will decrease coverage by 0.01%.
The diff coverage is 53.84%.

❗ Current head e8e7282 differs from pull request most recent head 5e2cc32. Consider uploading reports for the commit 5e2cc32 to get more accurate results

@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
- Coverage   93.39%   93.38%   -0.02%     
==========================================
  Files         679      679              
  Lines       66553    66569      +16     
  Branches     5875     5875              
==========================================
+ Hits        62159    62163       +4     
- Misses       4394     4406      +12     
Impacted Files Coverage Δ
.../components/table/src/composables/useFilterable.ts 71.42% <46.15%> (-14.06%) ⬇️
.../components/table/src/composables/useDataSource.ts 75.14% <60.00%> (+0.14%) ⬆️
...ckages/components/table/src/main/head/HeadCell.tsx 81.81% <80.00%> (+0.41%) ⬆️
packages/components/table/src/types.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a407920...5e2cc32. Read the comment docs.

@danranVm danranVm merged commit fff5022 into IDuxFE:main May 19, 2022
@danranVm danranVm deleted the fix-table-filterable branch May 19, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant