Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:watermark): prop content type error #944

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

liuzaijiang
Copy link
Contributor

@liuzaijiang liuzaijiang commented Jun 9, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

image

What is the new behavior?

content: { type: [String, Array] as PropType<string | string[]>, default: undefined, required: true },

Other information

@idux-bot
Copy link

idux-bot bot commented Jun 9, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #944 (8d59c93) into main (25e403c) will decrease coverage by 0.44%.
The diff coverage is 46.88%.

❗ Current head 8d59c93 differs from pull request most recent head 3c1c780. Consider uploading reports for the commit 3c1c780 to get more accurate results

@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
- Coverage   93.23%   92.79%   -0.45%     
==========================================
  Files         683      692       +9     
  Lines       67033    67654     +621     
  Branches     7910     7913       +3     
==========================================
+ Hits        62500    62781     +281     
- Misses       4533     4873     +340     
Impacted Files Coverage Δ
.../cdk/resize/src/resize-observer/ResizeObserver.tsx 36.53% <ø> (ø)
packages/cdk/resize/src/resize-observer/types.ts 100.00% <ø> (ø)
...dk/resize/src/resize-observer/useResizeObserver.ts 95.12% <ø> (ø)
packages/cdk/resize/src/resize-observer/utils.ts 91.48% <ø> (ø)
packages/cdk/resize/src/resizable/useResizable.ts 9.49% <9.49%> (ø)
...ckages/cdk/drag-drop/src/draggable/useDraggable.ts 16.66% <11.11%> (ø)
packages/cdk/drag-drop/src/draggable/Draggable.tsx 28.98% <23.07%> (ø)
packages/cdk/resize/src/resizable/Resizable.tsx 36.00% <36.00%> (ø)
...ages/cdk/resize/src/resizable/ResizableHandler.tsx 43.47% <43.47%> (ø)
packages/cdk/resize/index.ts 97.61% <96.15%> (+1.96%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e403c...3c1c780. Read the comment docs.

@danranVm danranVm merged commit ae91476 into IDuxFE:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants