Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:modal): fix loading stop before hide #961

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

qingshan-dev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

确认按钮事件回调是一个 Promise,点击确认按钮后,按钮结束按钮加载状态再隐藏Modal, 在隐藏之前用户双击可能又触发了确认按钮的事件

What is the new behavior?

先隐藏 Modal 再将结束按钮加载状态 或者等 Modal 隐藏的动画结束后再结束按钮加载状态

Other information

@idux-bot
Copy link

idux-bot bot commented Jun 15, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #961 (4b1ce56) into main (56bd1b2) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   92.76%   92.72%   -0.04%     
==========================================
  Files         692      695       +3     
  Lines       67811    68052     +241     
  Branches     7931     7946      +15     
==========================================
+ Hits        62904    63104     +200     
- Misses       4907     4948      +41     
Impacted Files Coverage Δ
packages/components/modal/src/Modal.tsx 99.35% <100.00%> (-0.01%) ⬇️
...ages/components/select/src/utils/generateOption.ts 88.88% <0.00%> (-11.12%) ⬇️
packages/components/select/src/Select.tsx 88.88% <0.00%> (-4.79%) ⬇️
...ponents/select/src/composables/useSelectedState.ts 85.88% <0.00%> (-4.02%) ⬇️
...mponents/select/src/composables/useGetOptionKey.ts 89.58% <0.00%> (-3.10%) ⬇️
...kages/pro/transfer/src/content/ProTransferList.tsx 92.38% <0.00%> (-1.74%) ⬇️
...ges/cdk/scroll/src/strategy/blockScrollStrategy.ts 84.61% <0.00%> (-1.65%) ⬇️
.../transfer/src/composables/useTransferOperations.ts 93.18% <0.00%> (-0.64%) ⬇️
...es/components/select/src/composables/useOptions.ts 97.48% <0.00%> (-0.26%) ⬇️
packages/cdk/scroll/src/utils.ts 83.55% <0.00%> (-0.22%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56bd1b2...4b1ce56. Read the comment docs.

@danranVm danranVm merged commit 8f3f696 into IDuxFE:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants