Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:table): set expandable trigger button type #962

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

在 form 组件中使用 table 的展开功能时,会触发表单组件的 submit, 导致页面刷新。

需要给 button 添加一个 type='button'

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Jun 16, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #962 (1a8f6f4) into main (6b36b31) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files         695      695           
  Lines       68054    68054           
  Branches     7947     7947           
=======================================
  Hits        63106    63106           
  Misses       4948     4948           
Impacted Files Coverage Δ
packages/components/carousel/src/Carousel.tsx 100.00% <100.00%> (ø)
...ckages/components/table/src/main/body/BodyCell.tsx 87.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b36b31...1a8f6f4. Read the comment docs.

@danranVm danranVm merged commit a59b764 into IDuxFE:main Jun 16, 2022
@danranVm danranVm deleted the fix-button-type branch June 16, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant