-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comp:modal): add draggable props (#905) #966
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #966 +/- ##
==========================================
- Coverage 92.89% 92.79% -0.10%
==========================================
Files 700 703 +3
Lines 68541 68808 +267
Branches 8025 8039 +14
==========================================
+ Hits 63668 63848 +180
- Misses 4873 4960 +87
Continue to review full report at Codecov.
|
a8032d1
to
5919e7d
Compare
5919e7d
to
be0ea48
Compare
sourceElement.setAttribute('draggable', 'true') | ||
sourceElement.classList.add('cdk-draggable') | ||
|
||
!options?.handle && sourceElement.classList.add('cdk-draggable') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其实我感觉这里干脆去掉吧,这种 composable 尽可能更加纯粹些,少一些 dom 相关的操作吧。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
由用户去定义吗
be0ea48
to
6b7bf8f
Compare
6b7bf8f
to
7da45e8
Compare
feat(cdk:drag-drop): add handle&reset api
7da45e8
to
00f8737
Compare
feat(cdk:drag-drop): add handle&reset api
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
Other information