Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:modal): the default header size should be 'md' #969

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

header 使用对象的方式去配置时尺寸大小变成 sm

What is the new behavior?

默认的 header 的 size 为 md

Other information

@idux-bot
Copy link

idux-bot bot commented Jun 21, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #969 (d1764b1) into main (4bda54b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #969   +/-   ##
=======================================
  Coverage   92.88%   92.89%           
=======================================
  Files         700      700           
  Lines       68559    68541   -18     
  Branches     8031     8025    -6     
=======================================
- Hits        63684    63668   -16     
+ Misses       4875     4873    -2     
Impacted Files Coverage Δ
packages/components/_private/footer/index.ts 100.00% <ø> (ø)
packages/components/_private/footer/src/types.ts 100.00% <100.00%> (ø)
packages/components/_private/header/src/Header.tsx 100.00% <100.00%> (ø)
packages/components/card/src/Card.tsx 99.24% <100.00%> (ø)
packages/components/date-picker/src/types.ts 100.00% <100.00%> (ø)
packages/components/drawer/src/DrawerWrapper.tsx 83.38% <100.00%> (-0.11%) ⬇️
packages/components/header/src/types.ts 100.00% <100.00%> (ø)
packages/components/modal/src/ModalWrapper.tsx 81.08% <100.00%> (+0.03%) ⬆️
packages/components/popover/src/Popover.tsx 100.00% <100.00%> (ø)
packages/components/table/__tests__/table.spec.ts 99.41% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bda54b...d1764b1. Read the comment docs.

@danranVm danranVm merged commit 437a6ce into IDuxFE:main Jun 21, 2022
@danranVm danranVm deleted the fix-private-header-size branch June 21, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants