feat(comp:checkbox,comp:radio): add group vertical props #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #975 +/- ##
==========================================
- Coverage 92.79% 92.53% -0.26%
==========================================
Files 703 706 +3
Lines 68808 69024 +216
Branches 8040 8045 +5
==========================================
+ Hits 63848 63874 +26
- Misses 4960 5150 +190
Continue to review full report at Codecov.
|
danranVm
requested changes
Jun 23, 2022
| @@ -58,7 +59,7 @@ export default defineComponent({ | |||
| } | |||
| return ( | |||
| <div class={classes.value} style={style.value}> | |||
| {children} | |||
| <IxSpace vertical={vertical}>{children}</IxSpace> | |||
There was a problem hiding this comment.
Suggested change
| <IxSpace vertical={vertical}>{children}</IxSpace> | |
| {vertical ? <IxSpace vertical={true}>{children}</IxSpace> : {children}} |
否则会影响 gap 功能，radio 也这样改下。
| 'onUpdate:checked': { type: Function as PropType<(checked: CheckValue) => void> }, | ||
| onChange: { type: Function as PropType<(newChecked: CheckValue, oldChecked: CheckValue) => void> }, | ||
| onBlur: { type: Function as PropType<(evt: FocusEvent) => void> }, | ||
| onFocus: { type: Function as PropType<(evt: FocusEvent) => void> }, | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } as const 一下 |
radio 也一样
| onFocus: IxPropTypes.emit<(evt: FocusEvent) => void>(), | ||
| 'onUpdate:checked': { type: Function as PropType<(checked: CheckValue) => void> }, | ||
| onChange: { type: Function as PropType<(newChecked: CheckValue, oldChecked: CheckValue) => void> }, | ||
| onBlur: { type: Function as PropType<(evt: FocusEvent) => void> }, |
There was a problem hiding this comment.
Suggested change
| onBlur: { type: Function as PropType<(evt: FocusEvent) => void> }, | |
| onBlur: { type: [Function, Array ]as PropType<MaybeArray<(evt: FocusEvent) => void>> }, |
其他的事件类型也一并改下。
tuchg
force-pushed
the
feat/datasource_direction
branch
from
71af197
to
4402459
Compare
tuchg
force-pushed
the
feat/datasource_direction
branch
from
4402459
to
d81b99f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(comp:radio,checkbox): props replace to vue proptype
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
RadioGroupProps/CheckBoxGroupProps
verticalbooleantrue为垂直排列Other information