Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:card): add selection state and disabled state #983

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

lionnnnn
Copy link
Contributor

@lionnnnn lionnnnn commented Jun 27, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  1. card can not be selected or disabled.

What is the new behavior?

  1. card can be selected or disabled.

Other information

image

image

image

image

#972

@idux-bot
Copy link

idux-bot bot commented Jun 27, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #983 (a8a91c4) into main (ddd67e3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a8a91c4 differs from pull request most recent head 567457d. Consider uploading reports for the commit 567457d to get more accurate results

@@           Coverage Diff           @@
##             main     #983   +/-   ##
=======================================
  Coverage   92.66%   92.67%           
=======================================
  Files         706      706           
  Lines       69024    69109   +85     
  Branches     8044     8057   +13     
=======================================
+ Hits        63961    64046   +85     
  Misses       5063     5063           
Impacted Files Coverage Δ
packages/components/card/__tests__/card.spec.ts 100.00% <100.00%> (ø)
packages/components/card/src/Card.tsx 99.39% <100.00%> (+0.14%) ⬆️
packages/components/card/src/types.ts 100.00% <100.00%> (ø)
...es/components/tree/src/composables/useCheckable.ts 100.00% <100.00%> (ø)
packages/components/tree/src/utils/index.ts 86.30% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd67e3...567457d. Read the comment docs.

@lionnnnn lionnnnn force-pushed the fix-card-972 branch 3 times, most recently from f58d963 to f34bab0 Compare June 27, 2022 09:12
packages/components/card/docs/Index.zh.md Outdated Show resolved Hide resolved
packages/components/card/src/Card.tsx Outdated Show resolved Hide resolved
packages/components/card/src/Card.tsx Outdated Show resolved Hide resolved
packages/components/card/src/Card.tsx Outdated Show resolved Hide resolved
packages/components/card/src/Card.tsx Outdated Show resolved Hide resolved
packages/components/card/src/Card.tsx Outdated Show resolved Hide resolved
Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danranVm danranVm merged commit a263497 into IDuxFE:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants