Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:carousel): after click the same dot repeatedly, will not work #986

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Jun 28, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

image

  • 重复点击切换幻灯片的按钮后,组件就不能正常切换了。

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Jun 28, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #986 (fd4df2f) into main (a263497) will increase coverage by 0.00%.
The diff coverage is 61.53%.

❗ Current head fd4df2f differs from pull request most recent head 69f2574. Consider uploading reports for the commit 69f2574 to get more accurate results

@@           Coverage Diff           @@
##             main     #986   +/-   ##
=======================================
  Coverage   92.67%   92.67%           
=======================================
  Files         706      706           
  Lines       69110    69123   +13     
  Branches     8058     8064    +6     
=======================================
+ Hits        64045    64058   +13     
  Misses       5065     5065           
Impacted Files Coverage Δ
...components/carousel/src/composables/useStrategy.ts 72.48% <55.81%> (+1.97%) ⬆️
packages/components/carousel/src/Carousel.tsx 91.21% <88.88%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a263497...69f2574. Read the comment docs.

@danranVm danranVm merged commit 33e136e into IDuxFE:main Jun 28, 2022
@danranVm danranVm deleted the fix-comp-carousel-transition-event branch June 28, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant