Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:input-number): replace old control (#970) #994

Merged

Conversation

qingshan-dev
Copy link
Contributor

@qingshan-dev qingshan-dev commented Jul 2, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

原来左右加减,最小最大值时没有禁用,加减后失去了焦点,双击存在选中其他部分的内容

What is the new behavior?

交互现在调整为右侧上下加减,最小最大值时有禁用提示,加减时自动获取焦点,双击取消文字选中

Other information

@idux-bot
Copy link

idux-bot bot commented Jul 2, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 2, 2022

Codecov Report

Merging #994 (8138867) into main (05f22f3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #994   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files         305      305           
  Lines       28705    28742   +37     
  Branches     3476     3486   +10     
=======================================
+ Hits        27121    27158   +37     
  Misses       1584     1584           
Impacted Files Coverage Δ
...ckages/components/input-number/src/InputNumber.tsx 100.00% <100.00%> (ø)
...ages/components/input-number/src/useInputNumber.ts 81.98% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f22f3...8138867. Read the comment docs.

@qingshan-dev qingshan-dev force-pushed the input-number-replace-old-control branch 6 times, most recently from 1a96371 to 3ac6a5d Compare July 3, 2022 09:16
@qingshan-dev qingshan-dev force-pushed the input-number-replace-old-control branch from 3ac6a5d to 8138867 Compare July 3, 2022 16:29
@danranVm danranVm merged commit 1fad46a into IDuxFE:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants