Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill out column B "pollutant name" in META-Pollutant (now META-Variable) automatically #4

Closed
gabroko opened this issue Dec 22, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gabroko
Copy link
Contributor

gabroko commented Dec 22, 2022

should be possible, since info is in column A (ID)

@retostauffer retostauffer self-assigned this Jan 2, 2023
@retostauffer retostauffer added the enhancement New feature or request label Jan 2, 2023
@retostauffer retostauffer added this to the Version 0.2 milestone Jan 2, 2023
@retostauffer
Copy link
Collaborator

@gabroko

Implemented for version 0.2 (see note below). Questionable how useful this is as it is duplicated information (the last part of the ID corresponds to the variable name).

meta-variable

One idea would be to write a "long name", e.g., Relative Humidity if it is for RH. This is, however, not good from a programming perspective as a user could change one part but not update the other one - this would require additional checks/tests. Or simply leave this column out as the ID is fairly readable and is the unique key for everything.

Testing development version

If you want to test the development version you need to check out the correct branch (not yet in main branch). You can do so by calling:

install_github("IEA-EBC-Annex86/annex", ref = "version_0.2")    # Installs latest version of the version_0.2 branch

@retostauffer retostauffer changed the title fill out column B "pollutant name" in META-pollutant automatically fill out column B "pollutant name" in META-Pollutant (now META-Variable) automatically Jan 2, 2023
@gabroko
Copy link
Contributor Author

gabroko commented Feb 6, 2023

yes, agree, could be omitted

@retostauffer
Copy link
Collaborator

Code adjusted; following the same idea as for 'META-Room' (see #3) by (i) not duplicating the information but (ii) allow the user to add additional (optional) information if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants