Updated PEP8 #1003
Closed
Updated PEP8 #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Models.py PEP8 updated
|
Why are the changes spread over 2 PRs? |
|
@biswaz Are you talking about PRs 1002 and 1003? |
|
I'm talking about the 2 PRs. The accomplish a common goal, they should be
submitted as a single PR. This helps in CI and test. Please resubmit as a
single PR. Hope you're not making the changes in the Github web editor,
without proper testing.
…On Sat, Oct 13, 2018 at 9:03 PM Mohammed Rishad ***@***.***> wrote:
@biswaz <https://github.com/biswaz> Are you talking about PRs 1002 and
1003?
Or 2 commits in PR 1003.
If you are talking about PRs, they are different files.
I have put 2 PRs intentionally.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1003 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALy3ENbryYXgsZrPht_Co_xmHoNefHRhks5ukgfNgaJpZM4XNhgJ>
.
--
Regards
Biswas
Chair | IEEE Student Branch Government Engineering College Sreekrishnapuram
Palakkad
|
|
@biswaz PR closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.