Sam changes #118
Merged
Sam changes #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IETF-VPN-TYPEs innitial commit, includes: * Encapsulation Type * Tag-Type * Underlay Transport * Service Topology * Service Profiles
boucadair
requested changes
Jun 4, 2020
yang/IETF-04/ietf-vpn-types.yang
Outdated
| identity LDP { | ||
| base protocol-type ; | ||
| description | ||
| "Transport based on LDP."; |
There was a problem hiding this comment.
We need to provide a description of what is meant by transport on LDP. Please add a reference clause.
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
module-name change
boucadair
requested changes
Jun 5, 2020
|
|
||
| grouping service-status { | ||
| container status { | ||
| leaf admin-status { |
There was a problem hiding this comment.
I thought we agreed to have the timestamp for admin-status, but as an optional attribute.
| // this note | ||
| } | ||
|
|
||
| /* Feature */ |
There was a problem hiding this comment.
Shouldn't we include "common" features between L3SM/L3SN as well?
There was a problem hiding this comment.
Yes, I will start with it.
There was a problem hiding this comment.
My key question is @oscargdd @boucadair may I upload the L2NM in this repo?
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
boucadair
requested changes
Jun 5, 2020
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
Co-authored-by: boucadair <mohamed.boucadair@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Innitial proposal of the vpn-types.yang it includes:
Encapsulation Type
Tag-Type
Underlay Transport
Service Topology
Service Profiles