New database model #239
Open
New database model #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryan-brancotte
requested changes
Mar 4, 2022
.env-sample
Outdated
| @@ -0,0 +1,2 @@ | |||
| login= | |||
There was a problem hiding this comment.
please add the new credentials in the already existing config file settings.ini and add constant in settings.py which will make the credentials available in the app
| ('collection', models.ManyToManyField(blank=True, to='ifbcat_api.Collection')), | ||
| ('operating_system', models.ManyToManyField(blank=True, to='ifbcat_api.OperatingSystem')), | ||
| ('scientific_topics', models.ManyToManyField(blank=True, to='ifbcat_api.Topic')), | ||
| ('tool_credit', models.ManyToManyField(blank=True, to='ifbcat_api.ToolCredit')), |
There was a problem hiding this comment.
credit would be enough ?
| ('operating_system', models.ManyToManyField(blank=True, to='ifbcat_api.OperatingSystem')), | ||
| ('scientific_topics', models.ManyToManyField(blank=True, to='ifbcat_api.Topic')), | ||
| ('tool_credit', models.ManyToManyField(blank=True, to='ifbcat_api.ToolCredit')), | ||
| ('tool_licence', models.ForeignKey(blank=True, help_text='Licence of the tool.', null=True, on_delete=django.db.models.deletion.SET_NULL, to='ifbcat_api.licence')), |
There was a problem hiding this comment.
licence would be enough, and more accurate
| ('scientific_topics', models.ManyToManyField(blank=True, to='ifbcat_api.Topic')), | ||
| ('tool_credit', models.ManyToManyField(blank=True, to='ifbcat_api.ToolCredit')), | ||
| ('tool_licence', models.ForeignKey(blank=True, help_text='Licence of the tool.', null=True, on_delete=django.db.models.deletion.SET_NULL, to='ifbcat_api.licence')), | ||
| ('tool_type', models.ManyToManyField(blank=True, to='ifbcat_api.ToolType')), |
There was a problem hiding this comment.
more cleanup on the model is needed
ifbcat_api/urls.py
Outdated
| @@ -53,6 +54,8 @@ | |||
| # path('testapiview/', views.TestApiView.as_view()), | |||
| path('tool/<int:pk>/', views.ToolViewSet.as_view({'get': 'retrieve'})), | |||
| path('tool/<biotoolsID>/', views.ToolViewSet.as_view({'get': 'retrieve'})), | |||
| path('database/<int:pk>/', views.DatabaseViewSet.as_view({'get': 'retrieve'})), | |||
| path('tool/<fairsharingID>/', views.DatabaseViewSet.as_view({'get': 'retrieve'})), | |||
ifbcat_api/model/tool/database.py
Outdated
| @@ -0,0 +1,205 @@ | |||
| import json | |||
There was a problem hiding this comment.
File is not in the right place, should not be in tool/ directory
There was a problem hiding this comment.
File is not in the right place, should not be in
tool/directory
Moved to /model/
This was referenced Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #228