Pydantic 2 migration #119
Open
Pydantic 2 migration #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 26, 2023
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #119 +/- ##
=========================================
Coverage ? 53.76%
=========================================
Files ? 23
Lines ? 1129
Branches ? 115
=========================================
Hits ? 607
Misses ? 510
Partials ? 12 ☔ View full report in Codecov by Sentry. |
alvarolopez
force-pushed
the
pydantic2
branch
2 times, most recently
from
9acd943
to
1e38b70
Compare
Pydantic 2 has breaking API changes, the most important for us is the usage of compute_fields. The accounting system expects datetime fields to be returned as integers (i.e. epoch). We can use computed_fields for that, using properties. This way we can internally store datetime objects, and just conver them to integers when they are accessed. In order to do so, we define _epoch properties.
|
@alvarolopez any idea when this will be merged? I am waiting on this one since months. |
|
@thebe14 Pydantic 2 was released only at the end of June (https://docs.pydantic.dev/2.0/blog/pydantic-v2-final/). We need to double check that everything works as expected. |
|
@aidaph can you check everything is working as expected? LGTM. |
aidaph
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move Pydantic models to V2.