Skip to content

Commit

Permalink
Deprecate underscored options
Browse files Browse the repository at this point in the history
Do not use dry_run, extract_to and extract_from but rather dry-run,
extract-to and extract-from.
  • Loading branch information
alvarolopez committed May 24, 2017
1 parent d35fefc commit 345da26
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
6 changes: 4 additions & 2 deletions caso/extract/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,15 @@
]

cli_opts = [
cfg.StrOpt('extract_to',
cfg.StrOpt('extract-to',
deprecated_name='extract_to',
help='Extract record changes until this date. '
'If it is not set, we use now. If a server has '
'ended after this date, it will be included, but '
'the consuption reported will end on this date. '
'If no time zone is specified, UTC will be used.'),
cfg.StrOpt('extract_from',
cfg.StrOpt('extract-from',
deprecated_name='extract_from',
help='Extract records that have changed after this date. This '
'means that if a record has started before this date, and '
'it has changed after this date (i.e. it is still running '
Expand Down
3 changes: 2 additions & 1 deletion caso/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
]

cli_opts = [
cfg.BoolOpt('dry_run',
cfg.BoolOpt('dry-run',
deprecated_name='dry_run',
default=False,
help='Extract records but do not push records to SSM. This '
'will not update the last run date.'),
Expand Down
2 changes: 1 addition & 1 deletion doc/source/usage.rst
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ command line
your OpenStack deployment.
``caso-extract -h`` will show a complete list of available arguments.

Use the ``--extract_from`` argument to specify the date from when the records
Use the ``--extract-from`` argument to specify the date from when the records
should be extracted. If no value is set, then ``cASO`` will extract the records
from the last run. If equal to "None", then extract records from the beggining
of time. If not time zone is specified, UTC will be used.
Expand Down

0 comments on commit 345da26

Please sign in to comment.