Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agent around logo in Image 3 #1735

Closed
jpstroop opened this issue Dec 3, 2018 · 7 comments
Closed

Add agent around logo in Image 3 #1735

jpstroop opened this issue Dec 3, 2018 · 7 comments
Assignees
Labels
Approved-by-TRC Issue has been approved by the TRC image invalid normative

Comments

@jpstroop
Copy link
Member

jpstroop commented Dec 3, 2018

For consistency w/ Prezi

https://preview.iiif.io/api/image-prezi-rc2/api/presentation/3.0/#provider

@jpstroop jpstroop added this to the Image 3.0 - RC2 milestone Dec 3, 2018
@jpstroop jpstroop changed the title Change logo -> agent in Image 3 Add agent around logo in Image 3 Dec 3, 2018
@azaroth42
Copy link
Member

This is a normative change, but one that would be painful if we didn't do.

@azaroth42
Copy link
Member

Propose that we use this as the easy introduction / test case for the TRC process. The change is (one hopes) entirely uncontroversial.

@azaroth42 azaroth42 added Ready-for-TRC Normative changes ready for TRC review discuss and removed Ready-for-TRC Normative changes ready for TRC review labels Jan 23, 2019
@zimeon zimeon added Approved-by-TRC Issue has been approved by the TRC and removed discuss labels Feb 27, 2019
@zimeon
Copy link
Member

zimeon commented Feb 27, 2019

Issue approved by TRC vote

@tomcrane
Copy link
Contributor

This TRC issue approved provider for the Presentation API:
IIIF/trc#7
(Provider property/Agent with logo, homepage, etc.)

And this TRC issue approved multiple logo images in Image and Presentation:
IIIF/trc#3

So, I can make a PR that has providers in both APIs, with multiple logos premitted.

But do we have approval for adding the whole provider structure to the Image API?
https://preview.iiif.io/api/image-prezi-rc2/api/presentation/3.0/#provider

@azaroth42
Copy link
Member

I think the opposite is true. It's fine for Presentation, but we should be removing logo and requiredStatement/attribution from Image, per discussions.

We asked on two calls now, plus an email to -discuss and no one has spoken up in favor of keeping it.

I'll make an issue now that we're at that stage!

@tomcrane
Copy link
Contributor

tomcrane commented Mar 18, 2019

So, the immediate action is then to allow multiple logos in Prezi, to reflect IIIF/trc#3, and leave logo in Image (which is already [ .. ] in RC2) until a decision on #1787, which will need TRC approval.

I'll do the former now.

@azaroth42
Copy link
Member

Superceded by #1787. Now invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-by-TRC Issue has been approved by the TRC image invalid normative
Projects
None yet
Development

No branches or pull requests

4 participants