Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should explicit upscale (^) be required for pct:nnn? #1741

Closed
tomcrane opened this issue Dec 5, 2018 · 6 comments · Fixed by #1814
Closed

Should explicit upscale (^) be required for pct:nnn? #1741

tomcrane opened this issue Dec 5, 2018 · 6 comments · Fixed by #1814
Assignees
Labels
Approved-by-TRC Issue has been approved by the TRC editorial image normative

Comments

@tomcrane
Copy link
Contributor

tomcrane commented Dec 5, 2018

In the current draft, any upscaling operation must be indicated by a "^" (caret) in the size parameter.

For percentage size operations, this is technically redundant: pct:200 and ^pct:200 can only mean the same thing.

Which is better? Be consistent, so that upscaling is always indicated by a caret?
Or not require it on pct, as it is redundant?

@tomcrane
Copy link
Contributor Author

tomcrane commented Dec 5, 2018

(From Edinburgh meeting 2018-12-05)

@azaroth42 azaroth42 added this to the Image 3.0 - RC2 milestone Dec 5, 2018
@azaroth42
Copy link
Member

My preference is not to make any change but to note the weirdness explicitly in the spec. e.g. editorial issue to explain why pct:101 is invalid and you need to use ^pct:101. ^pct:99 isn't invalid, it's just pointless.

@zimeon
Copy link
Member

zimeon commented Dec 5, 2018

Agreed but I'd add that pct:99 is canonical, ^pct:99 isn't.

@jpstroop
Copy link
Member

jpstroop commented Dec 5, 2018

Or we could just stop supporting pct: 😈

@azaroth42
Copy link
Member

@mikeapp: By leaving ^ in, you can distinguish between don't implement upscaling (501) and bad request for upscaling (400)

@azaroth42
Copy link
Member

Editors agree -- clarification about the usage of ^ and pct, no actual normative change.

@mikeapp mikeapp self-assigned this Apr 15, 2019
@azaroth42 azaroth42 added the Ready-for-TRC Normative changes ready for TRC review label Apr 17, 2019
@zimeon zimeon added Approved-by-TRC Issue has been approved by the TRC and removed Ready-for-TRC Normative changes ready for TRC review labels May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-by-TRC Issue has been approved by the TRC editorial image normative
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants