Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label in metadata in annotation resources inherits annotation context definition #1834

Closed
azaroth42 opened this issue Apr 19, 2019 · 6 comments · Fixed by #1851
Closed

label in metadata in annotation resources inherits annotation context definition #1834

azaroth42 opened this issue Apr 19, 2019 · 6 comments · Fixed by #1851
Assignees
Labels
Approved-by-TRC Issue has been approved by the TRC normative presentation

Comments

@azaroth42
Copy link
Member

azaroth42 commented Apr 19, 2019

Related to #1833 but worse ... If an annotation collection, annotation page, annotation or content resource referenced in an annotation has the metadata property, the currently prevailing definition of label is the one from the annotation context ... meaning it's a string. The same applies for requiredStatement as it inherits the metadata pattern.

Similarly the label of a provider on a content resource would inherit the annotation definition.

This just seems terrible.

Propose that we reconsider our stance on label :(

@azaroth42
Copy link
Member Author

There is also a warning block in 5.5 that is not in sync with the rest of the document.

@azaroth42
Copy link
Member Author

This is what we would currently serialize as:

{
  "type": "Annotation",
  "metadata": [ {"label": "string", "value": {"en": "value here"} } ]
}

@azaroth42
Copy link
Member Author

And the context solution:

"AnnotationCollection": {
  "@id": "as:OrderedCollection",
  "@context": [
    "http://www.w3.org/ns/anno.jsonld",
    {
     "label": {
        "@id": "rdfs:label",
       "@container": ["@language", "@set"],
       "@context": {
       "none": "@none"
     }
     },
     "partOf": {
       "@id": "dcterms:partOf",
       "@type": "@id",
       "@container": "@set"
      }
    }
  ]
}

@azaroth42
Copy link
Member Author

Editorial discussion 2019-05-15 - Internationalization and consistency of the API is more important than 100% consistency with the W3C model. Only limited damage in the normal case for native annotaitons, compared to significant issues in the regular case for IIIF usage.

Editors propose to take to TRC

@azaroth42 azaroth42 added the Ready-for-TRC Normative changes ready for TRC review label May 15, 2019
@zimeon
Copy link
Member

zimeon commented May 15, 2019

Copying comment from subsumed #1833 so we don't forget but can close that:

We currently say in 3.1.: the value of the property MUST be a JSON object, and that an Annotation Collection (etc) SHOULD have the label property.

And in 4.7 we say: properties on Annotation based resources use the context from the Web Annotation Data Model, whereas properties on classes defined by this specification use the IIIF Presentation API context’s definition.

This is normatively inconsistent

@zimeon
Copy link
Member

zimeon commented Jun 6, 2019

Approved by TRC in IIIF/trc#26

@zimeon zimeon added Approved-by-TRC Issue has been approved by the TRC and removed Ready-for-TRC Normative changes ready for TRC review labels Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-by-TRC Issue has been approved by the TRC normative presentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants