Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: drop Clickthrough as a distinct pattern in auth spec #2035

Closed
tomcrane opened this issue Aug 17, 2021 · 6 comments
Closed

Suggestion: drop Clickthrough as a distinct pattern in auth spec #2035

tomcrane opened this issue Aug 17, 2021 · 6 comments
Labels
Milestone

Comments

@tomcrane
Copy link
Contributor

Regardless of where #1959 goes, it seems that windows that open and close themselves without user interaction are going to be frowned upon as issuers of cookies or other credentials we want to be sent in third party contexts.

Implementing Glen's suggestion from https://iiif.slack.com/archives/C01CMCD760P/p1617204394093000?thread_ts=1617204171.090600&cid=C01CMCD760P, I have clickthrough working in Safari, at https://tomcrane.github.io/iiif-auth-client/

However - It still involves an interaction in a first party context, first time round:

image (5)

But you won't see that again unless a requestStorageAccess call fails

Having said this, the flow is horribly complicated.

We could achieve essentially the same result by dropping clickthrough as a distinct pattern, and making that experience the same as login, but with no credentials entered (just a button as above).

Users are going to have to see some sort of page, some of the time, to establish a first party relationship.

So to make implementation easier and reduce the spec surface area, just make this the same as login.
The spec does not mandate what happens at the login page anyway. The task you need to do for the server to set cookies could be anything:

  • press a button (clickthrough)
  • enter some credentials and press a button (login)
  • solve a puzzle
  • feed the machine-learning beast with your human insight
  • etc
@azaroth42
Copy link
Member

+1 from me.

@zimeon
Copy link
Member

zimeon commented Aug 17, 2021

+1 - Seems sensible to me to simplify by dropping the clickthrough specific pattern

@mikeapp
Copy link
Member

mikeapp commented Aug 17, 2021

+1 also

@tomcrane
Copy link
Contributor Author

Dropping clickthrough was begun in d4cf166 and refined further in subsequent commits for #2127

@tomcrane tomcrane added the Ready-for-Eds Editorial changes ready for Editorial review label Oct 25, 2022
@zimeon
Copy link
Member

zimeon commented Jun 6, 2023

Resolved. The IIIF Authorization Flow 2.0.0 specification was published 2023-06-02: https://iiif.io/api/search/2.0/ . Both "clickthrough" and "login" are replaced by the "active" pattern

@zimeon
Copy link
Member

zimeon commented Jun 6, 2023

Complete

@zimeon zimeon closed this as completed Jun 6, 2023
@zimeon zimeon removed discuss Ready-for-Eds Editorial changes ready for Editorial review labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants